<p><b>@benpicco</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/10556#discussion_r321782840">drivers/include/pca9685.h</a>:</p>
<pre style='color:#555'>> + */
+typedef enum {
+    PCA9685_OFF = 0,      /**< If /OE pin is HIGH, outputs are LOW */
+    PCA9685_OUT_DRV = 1,  /**< Outputs depend on the output driver mode
+                               pca9685_params_t::out_drv. If /OE pin is HIGH,
+                               it is high-impedance for PCA9685_OPEN_DRAIN,
+                               and HIGH for PCA9685_TOTEM_POLE */
+    PCA9685_HIHGH_Z = 2,  /**< If /OE pin is HIGH, outputs are high-impedance */
+} pca9685_out_ne_t;
+
+/**
+ * @brief   PCA9685 device initialization parameters
+ */
+typedef struct {
+
+    unsigned i2c_dev;   /**< I2C device, default I2C_DEV(0) */
</pre>
⬇️ Suggested change
<pre style="color: #555">-    unsigned i2c_dev;   /**< I2C device, default I2C_DEV(0) */
+    i2c_t i2c_dev;   /**< I2C device, default I2C_DEV(0) */
</pre>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/10556?email_source=notifications&email_token=ABE7WYAOS4SLGAEVEFDJ6G3QIJXUBA5CNFSM4GIYIQY2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCD5222A#pullrequestreview-284929384">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYGSXPTFLV7BRLRC7ZDQIJXUBANCNFSM4GIYIQYQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYEVADNB7XZ7NY7VURTQIJXUBA5CNFSM4GIYIQY2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCD5222A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/10556?email_source=notifications\u0026email_token=ABE7WYAOS4SLGAEVEFDJ6G3QIJXUBA5CNFSM4GIYIQY2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCD5222A#pullrequestreview-284929384",
"url": "https://github.com/RIOT-OS/RIOT/pull/10556?email_source=notifications\u0026email_token=ABE7WYAOS4SLGAEVEFDJ6G3QIJXUBA5CNFSM4GIYIQY2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCD5222A#pullrequestreview-284929384",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>