<p><b>@jcarrano</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/12031#discussion_r324095799">pkg/tlsf/contrib/native.c</a>:</p>
<pre style='color:#555'>> +#include "irq.h"
+#include "tlsf.h"
+#include "tlsf-malloc.h"
+#include "tlsf-malloc-internal.h"
+
+/* TODO: Add defines for other compilers */
+#if defined(__GNUC__) && !defined(__clang__)    /* Clang supports __GNUC__ but
+                                                 * not the alloc_size()
+                                                 * attribute */
+
+#define ATTR_MALLOC  __attribute__((malloc, alloc_size(1)))
+#define ATTR_CALLOC  __attribute__((malloc, alloc_size(1,2)))
+#define ATTR_MALIGN  __attribute__((alloc_align(1), alloc_size(2), malloc))
+#define ATTR_REALLOC  __attribute__((alloc_size(2)))
+
+#else /* No GNU C -> no alias attribute */
</pre>
<p>The comment is wrong, it should read:</p>
⬇️ Suggested change
<pre style="color: #555">-#else /* No GNU C -> no alias attribute */
+#else /* No GNU C -> no *alloc attribute */
</pre>

<p>The warning is not necessary: the "alloc" attributes are just hints to the compiler. In fact, I'm not 100% sure they help here.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/12031?email_source=notifications&email_token=ABE7WYDQLIRHBTHEY6AY5ODQJNIIZA5CNFSM4INDIP72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCEUNKBI#discussion_r324095799">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYDHLRQNMP43NES5KJ3QJNIIZANCNFSM4INDIP7Q">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYBI3W7APMA6HSM3A5DQJNIIZA5CNFSM4INDIP72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCEUNKBI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/12031?email_source=notifications\u0026email_token=ABE7WYDQLIRHBTHEY6AY5ODQJNIIZA5CNFSM4INDIP72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCEUNKBI#discussion_r324095799",
"url": "https://github.com/RIOT-OS/RIOT/pull/12031?email_source=notifications\u0026email_token=ABE7WYDQLIRHBTHEY6AY5ODQJNIIZA5CNFSM4INDIP72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCEUNKBI#discussion_r324095799",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>