<p><b>@benpicco</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11866#discussion_r324882834">cpu/cc3200/periph/gpio.c</a>:</p>
<pre style='color:#555'>> +    /* write to pin at portBase + pinOffset */
+    HWREG(portAddr + (ipin << 2)) =
+            _gpio_pin_value_mask(pin_to_gpio_num[gpio_pin_num(dev)], value);
+}
+
+/**
+ * @brief read a pins value
+ *
+ * @param dev external pin
+ * @return int current value of a pin
+ */
+int gpio_read(gpio_t dev)
+{
+    uint8_t port           = gpio_port_num(dev);
+    unsigned char ipin     = gpio_pin_mask(dev);
+    unsigned long portAddr = (unsigned long)gpio_port_by_num(port);
</pre>
<p>Again, use the integer types with defined size for register variables.<br>
It doesn't make any difference as by definition this code will only run on a single platform, but it's a question of style ;)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11866?email_source=notifications&email_token=ABE7WYCYBWS2N2PDKCUVM7TQJ7XR7A5CNFSM4IE6S5BKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCE4DQ4I#pullrequestreview-288897137">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYCDIEWOC4DHEKAXNHTQJ7XR7ANCNFSM4IE6S5BA">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYFZ7OLWHQY3KBW3NSLQJ7XR7A5CNFSM4IE6S5BKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCE4DQ4I.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11866?email_source=notifications\u0026email_token=ABE7WYCYBWS2N2PDKCUVM7TQJ7XR7A5CNFSM4IE6S5BKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCE4DQ4I#pullrequestreview-288897137",
"url": "https://github.com/RIOT-OS/RIOT/pull/11866?email_source=notifications\u0026email_token=ABE7WYCYBWS2N2PDKCUVM7TQJ7XR7A5CNFSM4IE6S5BKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCE4DQ4I#pullrequestreview-288897137",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>