<blockquote>
<p>Good catch again. First of all TCP options do not have a length maximum size of three bytes as stated in the PR descriptions.</p>
</blockquote>
<p>Thanks for pointing that out. I wanted to refer to fields, not bytes. Changed the commit message accordingly.</p>
<blockquote>
<p>Now to your PR. The Logic is fine, but usage of a magic numbers<br>
goes against the RIOT Styleguide. However you could place a constant in 'sys/include/net/tcp.h' and use it in the affected code segment.</p>
</blockquote>
<p>Thanks for the quick feedback. Added a constant in the file you referenced. I still think that's a bad idea to parse variable-length options with a packed struct though, but maybe that can be addressed separately.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/12249?email_source=notifications&email_token=ABE7WYGYTK57IQ4BOYBBPD3QJ7KV5A5CNFSM4IXBK7TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD62GIAY#issuecomment-531915779">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYEDWGRMWNAWFLUZNB3QJ7KV5ANCNFSM4IXBK7TA">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYD6XP3BH224EZNEMGDQJ7KV5A5CNFSM4IXBK7TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD62GIAY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/12249?email_source=notifications\u0026email_token=ABE7WYGYTK57IQ4BOYBBPD3QJ7KV5A5CNFSM4IXBK7TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD62GIAY#issuecomment-531915779",
"url": "https://github.com/RIOT-OS/RIOT/pull/12249?email_source=notifications\u0026email_token=ABE7WYGYTK57IQ4BOYBBPD3QJ7KV5A5CNFSM4IXBK7TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD62GIAY#issuecomment-531915779",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>