<h3>Contribution description</h3>
<p>Do not remove the '-D' and '-U' values from CFLAGS.<br>
This prevents issues where a '-D' could contain a space.</p>
<p>Some values way be duplicated from the 'riotbuild.h' header and the<br>
command line but with the same value so without conflict.</p>
<p>To not put too many things in the command line, the -DMODULE_NAME are<br>
only put in CFLAGS_WITH_MACROS.</p>
<p>Also, as now, the deferred value of CFLAGS is used for 'riotbuild.h',<br>
macros set after the inclusion of <code>Makefile.include</code> will be taken into<br>
account.</p>
<h3>Testing procedure</h3>
<p><strong>TODO</strong>:</p>
<p>Test if it fixes</p>
<ul>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="173750083" data-permission-text="Issue title is private" data-url="https://github.com/RIOT-OS/RIOT/issues/5776" data-hovercard-type="issue" data-hovercard-url="/RIOT-OS/RIOT/issues/5776/hovercard" href="https://github.com/RIOT-OS/RIOT/issues/5776">#5776</a></li>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="341943233" data-permission-text="Issue title is private" data-url="https://github.com/RIOT-OS/RIOT/issues/9589" data-hovercard-type="issue" data-hovercard-url="/RIOT-OS/RIOT/issues/9589/hovercard" href="https://github.com/RIOT-OS/RIOT/issues/9589">#9589</a></li>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="493181896" data-permission-text="Issue title is private" data-url="https://github.com/RIOT-OS/RIOT/issues/12219" data-hovercard-type="issue" data-hovercard-url="/RIOT-OS/RIOT/issues/12219/hovercard" href="https://github.com/RIOT-OS/RIOT/issues/12219">#12219</a></li>
</ul>
<h3>Issues/PRs references</h3>
<ul>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="173750083" data-permission-text="Issue title is private" data-url="https://github.com/RIOT-OS/RIOT/issues/5776" data-hovercard-type="issue" data-hovercard-url="/RIOT-OS/RIOT/issues/5776/hovercard" href="https://github.com/RIOT-OS/RIOT/issues/5776">#5776</a></li>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="341943233" data-permission-text="Issue title is private" data-url="https://github.com/RIOT-OS/RIOT/issues/9589" data-hovercard-type="issue" data-hovercard-url="/RIOT-OS/RIOT/issues/9589/hovercard" href="https://github.com/RIOT-OS/RIOT/issues/9589">#9589</a></li>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="493181896" data-permission-text="Issue title is private" data-url="https://github.com/RIOT-OS/RIOT/issues/12219" data-hovercard-type="issue" data-hovercard-url="/RIOT-OS/RIOT/issues/12219/hovercard" href="https://github.com/RIOT-OS/RIOT/issues/12219">#12219</a></li>
</ul>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/RIOT-OS/RIOT/pull/12262'>https://github.com/RIOT-OS/RIOT/pull/12262</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>makefiles: do not remove defines from CFLAGS</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/RIOT-OS/RIOT/pull/12262/files#diff-0">Makefile.include</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/RIOT-OS/RIOT/pull/12262/files#diff-1">makefiles/modules.inc.mk</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/RIOT-OS/RIOT/pull/12262.patch'>https://github.com/RIOT-OS/RIOT/pull/12262.patch</a></li>
  <li><a href='https://github.com/RIOT-OS/RIOT/pull/12262.diff'>https://github.com/RIOT-OS/RIOT/pull/12262.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/12262?email_source=notifications&email_token=ABE7WYAX6UEXCBWQAJMG2M3QKDNX5A5CNFSM4IXQGVMKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HL3RFMA">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYBGMUPAXS62Z6ZLJI3QKDNX5ANCNFSM4IXQGVMA">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYETDRJCMB2GENQV5JTQKDNX5A5CNFSM4IXQGVMKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HL3RFMA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/12262?email_source=notifications\u0026email_token=ABE7WYAX6UEXCBWQAJMG2M3QKDNX5A5CNFSM4IXQGVMKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HL3RFMA",
"url": "https://github.com/RIOT-OS/RIOT/pull/12262?email_source=notifications\u0026email_token=ABE7WYAX6UEXCBWQAJMG2M3QKDNX5A5CNFSM4IXQGVMKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HL3RFMA",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>