<p><b>@maribu</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/12082#discussion_r325140833">cpu/atmega_common/periph/gpio.c</a>:</p>
<pre style='color:#555'>> @@ -416,6 +416,25 @@ int gpio_init_int(gpio_t pin, gpio_mode_t mode, gpio_flank_t flank,
     return 0;
 }
 
+int gpio_set_cb(gpio_t pin, gpio_cb_t cb, void *arg)
+{
+    int8_t int_num = _int_num(pin);
+
+    if (int_num < 0) {
+        return -1;
+    }
+
+    if (cb) {
+        config[int_num].cb = cb;
+    }
+
+    if (arg) {
+        config[int_num].arg = arg;
+    }
</pre>
<p>Sure we really need this? I don't see a use case where someone whats to update the callback only <em><strong>and at the same time</strong></em> does not have access to the argument. But making the API more complex to fulfill this need definitely makes the API more complex to understand and use, which in turn will be a source of bugs.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/12082?email_source=notifications&email_token=ABE7WYHZGSUPONCX5LWTYO3QKDFLXA5CNFSM4IPPPQ2KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCE6UESA#discussion_r325140833">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYCJCJZ7SHBUTYCI3GDQKDFLXANCNFSM4IPPPQ2A">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYBNH3OOFA4VHW25JCLQKDFLXA5CNFSM4IPPPQ2KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCE6UESA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/12082?email_source=notifications\u0026email_token=ABE7WYHZGSUPONCX5LWTYO3QKDFLXA5CNFSM4IPPPQ2KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCE6UESA#discussion_r325140833",
"url": "https://github.com/RIOT-OS/RIOT/pull/12082?email_source=notifications\u0026email_token=ABE7WYHZGSUPONCX5LWTYO3QKDFLXA5CNFSM4IPPPQ2KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCE6UESA#discussion_r325140833",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>