<p><b>@aabadie</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11085#discussion_r326493473">sys/usb/usbus/cdc/acm/cdc_acm_stdio.c</a>:</p>
<pre style='color:#555'>> + *
+ * @}
+ */
+
+#include <stdio.h>
+
+#include "isrpipe.h"
+
+#include "usb/usbus.h"
+#include "usb/usbus/cdc/acm.h"
+
+#if MODULE_VFS
+#include "vfs.h"
+#endif
+
+static usbus_cdcacm_device_t cdcacm;
</pre>
<blockquote>
<p>How about adding something like [...]</p>
</blockquote>
<p>That might be cleanest. I tried something else using pseudomodules and conditional macros but I always end up having to <code>extern</code> something (a function in my second attempt).</p>
<p>Anyway, let's not change this in this PR. I can adapt this module like you suggest when I have something ready (I have already but I have to test it first).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11085?email_source=notifications&email_token=ABE7WYBQTHQHJ2FFZ66OSLLQKRXVDA5CNFSM4G262ZQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFMAYPA#discussion_r326493473">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYHO5TIJ4NUONEHOMQDQKRXVDANCNFSM4G262ZQQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYA6RN4O24VCEAU2BPDQKRXVDA5CNFSM4G262ZQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFMAYPA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11085?email_source=notifications\u0026email_token=ABE7WYBQTHQHJ2FFZ66OSLLQKRXVDA5CNFSM4G262ZQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFMAYPA#discussion_r326493473",
"url": "https://github.com/RIOT-OS/RIOT/pull/11085?email_source=notifications\u0026email_token=ABE7WYBQTHQHJ2FFZ66OSLLQKRXVDA5CNFSM4G262ZQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFMAYPA#discussion_r326493473",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>