<p><b>@aabadie</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/12281#discussion_r326534375">sys/net/gnrc/link_layer/lwmac/rx_state_machine.c</a>:</p>
<pre style='color:#555'>> @@ -183,9 +183,7 @@ static bool _send_wa(gnrc_netif_t *netif)
     /* Send WA */
     if (_gnrc_lwmac_transmit(netif, pkt) < 0) {
         LOG_ERROR("ERROR: [LWMAC-rx] Send WA failed.");
-        if (pkt != NULL) {
-            gnrc_pktbuf_release(pkt);
-        }
+        gnrc_pktbuf_release(pkt);
</pre>
<p>That's also why I'm unsure of this change. Looking at the code, <a href="https://github.com/RIOT-OS/RIOT/blob/master/sys/net/gnrc/link_layer/lwmac/rx_state_machine.c#L161">this line</a> already checks if <code>pkt</code> is not null and return if it's null. I don't know if code in between could change that non null pkt value.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/12281?email_source=notifications&email_token=ABE7WYGPYZQNYC63RZXKQRDQKSGI7A5CNFSM4IYTRZZ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFMODRI#discussion_r326534375">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYEJBKVA5IN4LPIZAO3QKSGI7ANCNFSM4IYTRZZQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYGG5AVZX5WD2QN774LQKSGI7A5CNFSM4IYTRZZ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFMODRI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/12281?email_source=notifications\u0026email_token=ABE7WYGPYZQNYC63RZXKQRDQKSGI7A5CNFSM4IYTRZZ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFMODRI#discussion_r326534375",
"url": "https://github.com/RIOT-OS/RIOT/pull/12281?email_source=notifications\u0026email_token=ABE7WYGPYZQNYC63RZXKQRDQKSGI7A5CNFSM4IYTRZZ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFMODRI#discussion_r326534375",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>