<p><b>@fjmolinas</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11940#discussion_r327602230">bootloaders/riotboot/Makefile</a>:</p>
<pre style='color:#555'>> @@ -8,7 +8,7 @@ BOARD ?= samr21-xpro
 FEATURES_REQUIRED += riotboot
 
 # Disable unused modules
-CFLAGS += -DNDEBUG -DLOG_LEVEL=LOG_NONE
+CFLAGS += -DNDEBUG -DLOG_LEVEL=LOG_NONE -DBOOTLOADER
</pre>
<p>I would keep the term <code>BOOTLOADER</code> or use <code>RIOT_BOOTLOADER</code> instead of <code>RIOTBOOT</code>. <code>riotboot</code> is associated with a module that any application can use so I think we should try and keep it [<strong>edit</strong>:semantically] separate from stuff only the bootloader needs.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11940?email_source=notifications&email_token=ABE7WYDTSU6GNQUK6H4YBODQLIHV7A5CNFSM4IIEMWPKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFW3NHQ#discussion_r327602230">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYFSL4ZLIA3B7JGNLUTQLIHV7ANCNFSM4IIEMWPA">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYGLHF7FCQKRLLUTBITQLIHV7A5CNFSM4IIEMWPKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFW3NHQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11940?email_source=notifications\u0026email_token=ABE7WYDTSU6GNQUK6H4YBODQLIHV7A5CNFSM4IIEMWPKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFW3NHQ#discussion_r327602230",
"url": "https://github.com/RIOT-OS/RIOT/pull/11940?email_source=notifications\u0026email_token=ABE7WYDTSU6GNQUK6H4YBODQLIHV7A5CNFSM4IIEMWPKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFW3NHQ#discussion_r327602230",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>