<h1>Contribution description</h1>
<p>The <code>nrfble</code> driver is working for all nrf-based CPUs (nrf51 and nrf52x), but the <code>radio_nrfble</code> feature is right now only and weirdly declared in <code>boards/common/nrf52/Makefile.features</code>. So the clean way would obviously be to declare that feature in <code>cpu/nrf5x_common/Makefile.features</code>, same as already done for <code>radio_nrfmin</code>.</p>
<p>Besides the structural cleanup, this change does furthermore enable <code>skald</code> to be build on <code>nrf51</code>-based platforms. This is intended and works as expected.</p>
<h3>Testing procedure</h3>
<p><code>make buildtest</code> for <code>examples/skald_x</code> should build all boards that were build before, and also for all <code>nrf51</code>-based ones.</p>
<p>Further, at least one <code>nrf51</code>-based board should be flashed with a <code>skald</code> example and its behavior should should be verified with any BLE scanner (e.g. use your phone or <code>examples/nimble_scanner</code> on any <code>nrf52</code>-based board).</p>
<h3>Issues/PRs references</h3>
<p>none</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/RIOT-OS/RIOT/pull/12313'>https://github.com/RIOT-OS/RIOT/pull/12313</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>cpu/nrf5x: decelare radio_nrfble feat for all nrfs</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/RIOT-OS/RIOT/pull/12313/files#diff-0">boards/common/nrf52/Makefile.features</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/RIOT-OS/RIOT/pull/12313/files#diff-1">cpu/nrf5x_common/Makefile.features</a>
    (1)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/RIOT-OS/RIOT/pull/12313.patch'>https://github.com/RIOT-OS/RIOT/pull/12313.patch</a></li>
  <li><a href='https://github.com/RIOT-OS/RIOT/pull/12313.diff'>https://github.com/RIOT-OS/RIOT/pull/12313.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/12313?email_source=notifications&email_token=ABE7WYBJVGUUT22WD4SN2QLQLW5MPA5CNFSM4I3DF7BKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HOCXEXA">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYHXJVQJ7UM6HAV4DATQLW5MPANCNFSM4I3DF7BA">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYB6Q3YEHMJW4DHB63DQLW5MPA5CNFSM4I3DF7BKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HOCXEXA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/12313?email_source=notifications\u0026email_token=ABE7WYBJVGUUT22WD4SN2QLQLW5MPA5CNFSM4I3DF7BKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HOCXEXA",
"url": "https://github.com/RIOT-OS/RIOT/pull/12313?email_source=notifications\u0026email_token=ABE7WYBJVGUUT22WD4SN2QLQLW5MPA5CNFSM4I3DF7BKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HOCXEXA",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>