<p><b>@benpicco</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/12324#discussion_r329358993">sys/include/net/gnrc/sixlowpan/frag/rb.h</a>:</p>
<pre style='color:#555'>>   * compiled in */
-#define gnrc_sixlowpan_frag_rbuf_remove(rbuf)       (void)(rbuf)
-#define gnrc_sixlowpan_frag_rbuf_dispatch_when_complete(rbuf, netif) \
+#define gnrc_sixlowpan_frag_rb_remove(rbuf)     (void)(rbuf)
+#define gnrc_sixlowpan_frag_rb_dispatch_when_complete(rbuf, netif) \
     (void)(rbuf); (void)(netif)
</pre>
<p>I'm not suggesting to change this here as this is just about moving functionality around and that style is used throughout the rest of the module, but generally an empty <code>static inline</code> function will achieve the same result with less way for something to go wrong.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/12324?email_source=notifications&email_token=ABE7WYD66OOFG6LYCY3PLR3QMDFVNA5CNFSM4I3NT2X2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGIJY7Q#pullrequestreview-294689918">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYFC7HXFX654SDHZASLQMDFVNANCNFSM4I3NT2XQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYEWIEAHSBPUPFV7LVLQMDFVNA5CNFSM4I3NT2X2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGIJY7Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/12324?email_source=notifications\u0026email_token=ABE7WYD66OOFG6LYCY3PLR3QMDFVNA5CNFSM4I3NT2X2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGIJY7Q#pullrequestreview-294689918",
"url": "https://github.com/RIOT-OS/RIOT/pull/12324?email_source=notifications\u0026email_token=ABE7WYD66OOFG6LYCY3PLR3QMDFVNA5CNFSM4I3NT2X2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGIJY7Q#pullrequestreview-294689918",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>