<p><b>@kaspar030</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/11818#discussion_r329628411">sys/suit/coap.c</a>:</p>
<pre style='color:#555'>> +    ssize_t res;
+    size_t pdu_len = (pkt->payload - (uint8_t *)pkt->hdr) + pkt->payload_len;
+    uint8_t *buf = (uint8_t*)pkt->hdr;
+
+    /* TODO: timeout random between between ACK_TIMEOUT and (ACK_TIMEOUT *
+     * ACK_RANDOM_FACTOR) */
+    uint32_t timeout = COAP_ACK_TIMEOUT * US_PER_SEC;
+    unsigned tries_left = COAP_MAX_RETRANSMIT + 1;  /* add 1 for initial transmit */
+    while (tries_left) {
+
+        res = sock_udp_send(sock, buf, pdu_len, NULL);
+        if (res <= 0) {
+            DEBUG("nanocoap: error sending coap request, %d\n", (int)res);
+            break;
+        }
+
</pre>
<pre><code>while (block_timeout < xtimer_now_usec())
</code></pre>
<p>This'll probably fail every ~71 minutes. I've tried to factor out the timeout handling, mind to take a look?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/11818?email_source=notifications&email_token=ABE7WYCI56DLVQOJAOQZ25TQMIIIXA5CNFSM4H63VM7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGK75EA#discussion_r329628411">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYF4W5GV2N5PXHJEB5TQMIIIXANCNFSM4H63VM7A">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABE7WYHSVCQRO7QDZT2J7HLQMIIIXA5CNFSM4H63VM7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGK75EA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/11818?email_source=notifications\u0026email_token=ABE7WYCI56DLVQOJAOQZ25TQMIIIXA5CNFSM4H63VM7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGK75EA#discussion_r329628411",
"url": "https://github.com/RIOT-OS/RIOT/pull/11818?email_source=notifications\u0026email_token=ABE7WYCI56DLVQOJAOQZ25TQMIIIXA5CNFSM4H63VM7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGK75EA#discussion_r329628411",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>