<p></p>
<p><b>@fjmolinas</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/14045#discussion_r423613009">drivers/include/mtd_mapper.h</a>:</p>
<pre style='color:#555'>> @@ -96,7 +96,7 @@ typedef struct {
 typedef struct {
     mtd_dev_t mtd;                  /**< MTD context                         */
     mtd_mapper_parent_t *parent;    /**< MTD mapper parent device            */
-    uint32_t offset;                /**< Offset address to start this region */
+    uint32_t offset;                /**< Sector offset to start of this region */
</pre>
<p><code>first_sector</code> or <code>base_sector</code>?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/14045#discussion_r423613009">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYBJ5F6ZJI5XZANME5TRREMZDANCNFSM4M4PQNNQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYHRDDUJ7OO2HIGGQ6TRREMZDA5CNFSM4M4PQNN2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODBXGCCQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/14045#discussion_r423613009",
"url": "https://github.com/RIOT-OS/RIOT/pull/14045#discussion_r423613009",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>