<p></p>
<p><b>@miri64</b> commented on this pull request.</p>

<p>Looking good so far. Some nits to the doc. Let me do some testing also.</p><hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/14022#discussion_r423741664">sys/include/net/gnrc/ipv6/nib.h</a>:</p>
<pre style='color:#555'>> @@ -288,6 +288,24 @@ enum {
     GNRC_IPV6_NIB_ROUTE_INFO_TYPE_NSC,
 };
 
+/**
+ * @brief   Types for GNRC_NETIF_BUS_NIB per-interface message bus
+ */
+typedef enum {
+    /**
+     * @brief   Address becomes valid
+     *
+     * The event is generated when an address on the interface becomes valid.
+     * The message payload contains a pointer to the respective
+     * @ref ipv6_addr_t struct.
+     *
+     * <b>Note:</b> If the address on the interface changed between sending
</pre>
⬇️ Suggested change
<pre style="color: #555">-     * <b>Note:</b> If the address on the interface changed between sending
+     * @note If the address on the interface changed between sending
</pre>


<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/14022#discussion_r423742185">sys/include/net/gnrc/ipv6/nib.h</a>:</p>
<pre style='color:#555'>> @@ -288,6 +288,24 @@ enum {
     GNRC_IPV6_NIB_ROUTE_INFO_TYPE_NSC,
 };
 
+/**
+ * @brief   Types for GNRC_NETIF_BUS_NIB per-interface message bus
+ */
+typedef enum {
+    /**
+     * @brief   Address becomes valid
+     *
+     * The event is generated when an address on the interface becomes valid.
</pre>
<p>Maybe also add a note, that this does not fire, if the address is added manually with VALID set.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/14022#pullrequestreview-410052172">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYEJHFZ6YSPNPSCE333RRFG6XANCNFSM4MZO35ZA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYATMZXTDPV5TKW3PTDRRFG6XA5CNFSM4MZO35ZKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODBYOMTA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/14022#pullrequestreview-410052172",
"url": "https://github.com/RIOT-OS/RIOT/pull/14022#pullrequestreview-410052172",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>