<p></p>
<p><b>@leandrolanzieri</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/14019#discussion_r425768085">drivers/include/at.h</a>:</p>
<pre style='color:#555'>>  #endif
 
 /**
- * @brief default OK reply of an AT device.
+ * @brief Size of buffer used to process unsolicited result code data.
+ */
+#if defined(MODULE_AT_URC) || DOXYGEN
+#if defined(MODULE_AT_URC) || DOXYGEN
</pre>
<p>Duplicated?</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/14019#discussion_r425768702">drivers/include/at.h</a>:</p>
<pre style='color:#555'>> +#ifdef CONFIG_AT_BUF_SIZE_EXP
+#define CONFIG_AT_BUF_SIZE  (1<<CONFIG_AT_BUF_SIZE_EXP)
+#endif
</pre>
<p>I think this could be like this</p>
⬇️ Suggested change
<pre style="color: #555">-#ifdef CONFIG_AT_BUF_SIZE_EXP
-#define CONFIG_AT_BUF_SIZE  (1<<CONFIG_AT_BUF_SIZE_EXP)
-#endif
+#ifdef CONFIG_AT_BUF_SIZE_EXP
+#define CONFIG_AT_BUF_SIZE_EXP (7)
+#endif
+
+#define AT_BUF_SIZE   (1<<CONFIG_AT_BUF_SIZE_EXP)
</pre>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/14019#pullrequestreview-412603827">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYA2EMNLXNMWUNJWPELRRUY33ANCNFSM4MZLEWHA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYGTJS6MDQCWKUL3D3LRRUY33A5CNFSM4MZLEWHKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODCL5LMY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/14019#pullrequestreview-412603827",
"url": "https://github.com/RIOT-OS/RIOT/pull/14019#pullrequestreview-412603827",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>