<p></p>
<p><b>@leandrolanzieri</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/13989#discussion_r426605874">drivers/saul/init_devs/auto_init_tmp00x.c</a>:</p>
<pre style='color:#555'>> @@ -69,12 +70,12 @@ void auto_init_tmp00x(void)
             LOG_ERROR("[auto_init_saul] error set active tmp00x #%u\n", i);
             continue;
         }
-#if TMP00X_USE_LOW_POWER
-        if (tmp00x_set_standby(&tmp00x_devs[i]) != TMP00X_OK) {
-            LOG_ERROR("[auto_init_saul] error set standby tmp00x #%u\n", i);
-            continue;
-        }
-#endif
+    if (IS_ACTIVE(CONFIG_TMP00X_USE_LOW_POWER)) {
</pre>
<p>Indentation is off</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/13989#discussion_r426607344">drivers/tmp00x/tmp00x.c</a>:</p>
<pre style='color:#555'>> +
+    if (IS_ACTIVE(CONFIG_TMP00X_USE_LOW_POWER)) {
+        if (tmp00x_set_active(dev)) {
+            return TMP00X_ERROR;
+        }
+        xtimer_usleep(CONFIG_TMP00X_CONVERSION_TIME);
+    }
+
+    if (IS_ACTIVE(CONFIG_TMP00X_USE_RAW_VALUES)) {
+        if ((ret = tmp00x_read(dev, to, ta, &drdy)) < 0) {
+            return ret;
+        }
+
+        if (!drdy) {
+            if (IS_ACTIVE(CONFIG_TMP00X_USE_LOW_POWER)) {
+            tmp00x_set_standby(dev);
</pre>
<p>Indentation</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/13989#discussion_r426610574">drivers/tmp00x/tmp00x.c</a>:</p>
<pre style='color:#555'>> +        if (!drdy) {
+            if (IS_ACTIVE(CONFIG_TMP00X_USE_LOW_POWER)) {
+            tmp00x_set_standby(dev);
+            }
+            return -TMP00X_ERROR;
+        }
+    }
+    else {
+        if ((ret = tmp00x_read(dev, &rawvolt, &rawtemp, &drdy)) < 0) {
+            return ret;
+        }
+
+        if (!drdy) {
+            if (IS_ACTIVE(CONFIG_TMP00X_USE_LOW_POWER)) {
+                tmp00x_set_standby(dev);
+            }
         return -TMP00X_ERROR;
</pre>
<p>Same here</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/13989#discussion_r426611062">drivers/tmp00x/tmp00x.c</a>:</p>
<pre style='color:#555'>>          return -TMP00X_ERROR;
-    }
-#else
-    if ((ret = tmp00x_read(dev, &rawvolt, &rawtemp, &drdy)) < 0) {
-        return ret;
-    }
-
-    if (!drdy) {
-#if TMP00X_USE_LOW_POWER
-        tmp00x_set_standby(dev);
-#endif
-        return -TMP00X_ERROR;
-    }
-
+        }
     tmp00x_convert(rawvolt, rawtemp,  &tamb, &tobj);
     *ta = (int16_t)(tamb*100);
     *to = (int16_t)(tobj*100);
</pre>
<p>Same here</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/13989#pullrequestreview-413567476">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYGFH4WRUUVFNK2SWSLRSEXGPANCNFSM4MVNWNVQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYDZIVWBKNP7VKMMB4TRSEXGPA5CNFSM4MVNWNV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODCTIT5A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/13989#pullrequestreview-413567476",
"url": "https://github.com/RIOT-OS/RIOT/pull/13989#pullrequestreview-413567476",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>