<p></p>
<p><b>@leandrolanzieri</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/14047#discussion_r427199206">drivers/mrf24j40/mrf24j40_netdev.c</a>:</p>
<pre style='color:#555'>> @@ -330,6 +330,20 @@ static int _get(netdev_t *netdev, netopt_t opt, void *val, size_t max_len)
             }
             break;
 
+#ifdef MODULE_NETDEV_IEEE802154_OQPSK
+
+        case NETOPT_IEEE802154_PHY:
+            assert(max_len >= sizeof(int8_t));
+            *(uint8_t *)val = IEEE802154_PHY_OQPSK;
+            return sizeof(uint8_t);
+
+        case NETOPT_OQPSK_RATE:
</pre>
<p>Is this netopt now being used to activate the proprietary mode in radios? From the user perspective wouldn't it be misleading that, if using different radios, when this is set communication does not longer work?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/14047#pullrequestreview-414314217">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYHL3TP2SVAZB2VOHNTRSJN57ANCNFSM4M42FPUA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYALD2AHORS6GKZTCSLRSJN57A5CNFSM4M42FPUKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODCY652I.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/14047#pullrequestreview-414314217",
"url": "https://github.com/RIOT-OS/RIOT/pull/14047#pullrequestreview-414314217",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>