<p></p>
<p><b>@basilfx</b> commented on this pull request.</p>

<p>A few comments here and there.</p><hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/15427#discussion_r524689905">Makefile.include</a>:</p>
<pre style='color:#555'>> @@ -730,7 +730,7 @@ debug-server:
        $(call check_cmd,$(DEBUGSERVER),Debug server program)
        $(DEBUGSERVER) $(DEBUGSERVER_FLAGS)
 
-emulate:
+emulate: all
</pre>
<p>Out of curiosity: why is this needed?</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/15427#discussion_r524690339">boards/cc2538dk/dist/board.resc</a>:</p>
<pre style='color:#555'>> @@ -1,30 +1,35 @@
-mach create
-using sysbus
-machine LoadPlatformDescription @platforms/cpus/cc2538.repl
+:name: CC2538
+:description: This script runs Contiki-NG hello-world example on CC2538.
+
+$name?="CC2538"
+$bin?=@https://dl.antmicro.com/projects/renode/cc2538-contiki_hello_world.elf-s_242120-08fc83d11f790ccc1aa46abfdfc9c2e1a94baed2
</pre>
<p>Check my version at <a href="https://github.com/basilfx/RIOT/tree/feature/renode">https://github.com/basilfx/RIOT/tree/feature/renode</a>.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/15427#discussion_r524691191">boards/ikea-tradfri/Makefile.features</a>:</p>
<pre style='color:#555'>> @@ -10,5 +10,8 @@ FEATURES_PROVIDED += periph_spi
 FEATURES_PROVIDED += periph_timer
 FEATURES_PROVIDED += periph_uart periph_uart_modecfg
 
+# Various other features (if any)
+FEATURES_PROVIDED += emulator_renode
</pre>
<p>I see this at multiple places, but it doesn't seem to be used, right?</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/15427#discussion_r524695027">dist/tools/renode/run-renode.sh</a>:</p>
<pre style='color:#555'>>  # Default Renode command
-: ${RENODE:=renode}
+if [ ! -f "${RENODE}" ]; then
</pre>
<p>Isn't <code>${RENODE:=renode}</code> doing the same?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/15427#pullrequestreview-531844351">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYFYNBORY5L2SFJIAR3SQGTI3ANCNFSM4TRTRCLQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYDZWMIPMHQLJARZ5ZTSQGTI3A5CNFSM4TRTRCL2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOD6ZUZ7Y.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/15427#pullrequestreview-531844351",
"url": "https://github.com/RIOT-OS/RIOT/pull/15427#pullrequestreview-531844351",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>