<p></p>
<p><b>@benpicco</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/15435#discussion_r524697882">sys/net/gnrc/netif/gnrc_netif.c</a>:</p>
<pre style='color:#555'>> @@ -1521,6 +1521,9 @@ static void _send(gnrc_netif_t *netif, gnrc_pktsnip_t *pkt, bool push_back)
         }
         else {
             LOG_ERROR("gnrc_netif: can't queue packet for sending\n");
+            /* If we got here, it means the device was busy and the pkt queue
+             * was full. The packet should be dropped here anyway */
+            gnrc_pktbuf_release(pkt, ENOMEM);
</pre>

⬇️ Suggested change
<pre style="color: #555">-            gnrc_pktbuf_release(pkt, ENOMEM);
+            gnrc_pktbuf_release_error(pkt, ENOMEM);
</pre>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/15435#pullrequestreview-531848290">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYG3X4Z6P6KMPUWVRALSQGTO5ANCNFSM4TTOATKQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYBXEUFOZJADER5HQJ3SQGTO5A5CNFSM4TTOATK2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOD6ZVYYQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/15435#pullrequestreview-531848290",
"url": "https://github.com/RIOT-OS/RIOT/pull/15435#pullrequestreview-531848290",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>