<p></p>
<p><b>@benpicco</b> commented on this pull request.</p>

<p>some whitespace nitpicks</p><hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/15735#discussion_r554590705">cpu/esp_common/esp-now/esp_now_params.h</a>:</p>
<pre style='color:#555'>> @@ -103,9 +103,9 @@
  */
 typedef struct
 {
-    uint8_t* key;         /**< key of type uint8_t [16] or NULL (no encryption) */
+    const uint8_t* key;         /**< key of type uint8_t [16] or NULL (no encryption) */
</pre>

⬇️ Suggested change
<pre style="color: #555">-    const uint8_t* key;         /**< key of type uint8_t [16] or NULL (no encryption) */
+    const uint8_t* key;     /**< key of type uint8_t [16] or NULL (no encryption) */
</pre>


<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/15735#discussion_r554590750">cpu/esp_common/esp-now/esp_now_params.h</a>:</p>
<pre style='color:#555'>>      uint32_t scan_period; /**< Period at which the node scans for other nodes */
-    char*    softap_pass; /**< Passphrase used for the SoftAP interface */
+    const char*    softap_pass; /**< Passphrase used for the SoftAP interface */
</pre>

⬇️ Suggested change
<pre style="color: #555">-    const char*    softap_pass; /**< Passphrase used for the SoftAP interface */
+    const char* softap_pass; /**< Passphrase used for the SoftAP interface */
</pre>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/15735#pullrequestreview-564879419">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYCS5VW6ZX5RNO2MBE3SZHJIJANCNFSM4V4MM5CQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYHGIHJUDMULXCOZHS3SZHJIJA5CNFSM4V4MM5C2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEGVWAOY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/15735#pullrequestreview-564879419",
"url": "https://github.com/RIOT-OS/RIOT/pull/15735#pullrequestreview-564879419",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>