<p></p>
<p><b>@benpicco</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16469#discussion_r630158033">boards/seeeduino_XIAO/board.c</a>:</p>
<pre style='color:#555'>> +/*
+ * Copyright (C)  2021 Franz Freitag, Justus Krebs, Nick Weiler 
+ *
+ * This file is subject to the terms and conditions of the GNU Lesser
+ * General Public License v2.1. See the file LICENSE in the top level
+ * directory for more details.
+ */
+
+/**
+ * @ingroup     boards_seeedurino_XIAO
+ * @{
+ *
+ * @file
+ * @brief       Board specific implementations for the Seeeduino XIAO board
+ *
+ * @author      Franz Freitag <franz.freitag@st.ovgu.de>, Justus Krebs <justus.krebs@st.ovgu.de>, Nick Weiler <nick.weiler@st.ovgu.de>, Benjamin Valentin <benpicco@googlemail.com>
</pre>
<p>add some line breaks here</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16469#discussion_r630158544">boards/seeeduino_XIAO/board.c</a>:</p>
<pre style='color:#555'>> +/* GD25Q32C */
+static const mtd_spi_nor_params_t _seeduino_XIAO_nor_params = {
</pre>
<p>Does the board really have SPI flash?<br>
I didn't find it on the <a href="https://files.seeedstudio.com/wiki/Seeeduino-XIAO/res/Seeeduino-XIAO-v1.0-SCH-191112.pdf" rel="nofollow">schematics</a></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/16469#pullrequestreview-656694417">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYB4AM6NNC7UVJK2CSDTNEVQPANCNFSM44VKVYDA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYHY5WOIKL5KINXRQNDTNEVQPA5CNFSM44VKVYDKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOE4SFZEI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/16469#pullrequestreview-656694417",
"url": "https://github.com/RIOT-OS/RIOT/pull/16469#pullrequestreview-656694417",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>