<p></p>
<p><b>@silkeh</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/12509#discussion_r635168501">tests/driver_epd_bw_spi_disp_dev/main.c</a>:</p>
<pre style='color:#555'>> +        /* Use full refreshes for the full-size logo */
+        epd_bw_spi_set_partial(dev, false);
</pre>
<p>Yes, because the <code>disp_dev</code> API doesn't cover this fundamental property of e-paper displays.</p>
<blockquote>
<p>better check for the bounds used with the disp_dev map function and call the epd_bw_spi_update_part/epd_bw_spi_update_full accordingly.</p>
</blockquote>
<p>The bounds don't necessarily have anything to do with wanting to do a full/partial refresh. The main reason to do a full refresh is to resolve the ghosting, otherwise a partial refresh will always give a better experience (and lower power draw).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/12509#discussion_r635168501">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYBHAVPYBTAKNEYHUDDTOORVJANCNFSM4JCQDDXQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYDG55U6DGIOPQIQSLLTOORVJA5CNFSM4JCQDDX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOE6DCSCA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/12509#discussion_r635168501",
"url": "https://github.com/RIOT-OS/RIOT/pull/12509#discussion_r635168501",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>