<p></p>
<p><b>@aabadie</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16509#discussion_r642902568">Makefile.include</a>:</p>
<pre style='color:#555'>> +# inlcude clang-tidy
+include $(RIOTMAKE)/clang_tidy.inc.mk
</pre>
<p>Why not only include this if llvm toolchain is used (there's also a typo btw):</p>

⬇️ Suggested change
<pre style="color: #555">-# inlcude clang-tidy
-include $(RIOTMAKE)/clang_tidy.inc.mk
+# include clang-tidy if llvm toolchain is used
+ifeq (llvm,$(TOOLCHAIN))
+  include $(RIOTMAKE)/clang_tidy.inc.mk
+endif
</pre>

<p>Then there's no need for the error message in <code>clang_tidy.inc.mk</code> (that I would rename <code>clang-tidy.inc.mk</code> but that's a matter of taste and I won't insist)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/16509#pullrequestreview-672808795">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYHKDJDYNYDJPVYMOFDTQSMNTANCNFSM45WHOEFA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYEDIW5PKMQVKW6CJG3TQSMNTA5CNFSM45WHOEFKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFAND6WY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/16509#pullrequestreview-672808795",
"url": "https://github.com/RIOT-OS/RIOT/pull/16509#pullrequestreview-672808795",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>