<p></p>
<p><b>@leandrolanzieri</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16483#discussion_r658606555">Makefile.base</a>:</p>
<pre style='color:#555'>> @@ -67,9 +67,11 @@ ifeq ($(strip $(ASSMSRC))$(NO_AUTO_SRC),)
   ASSMSRC := $(wildcard *.S)
 endif
 
-ifneq (,$(SRCXX))
-  ifeq (,$(filter cpp,$(FEATURES_USED)))
-    $(error Found C++ source, but feature "cpp" is not used. Add "FEATURES_REQUIRED += cpp")
+ifneq (1,$(TEST_KCONFIG))
+  ifneq (,$(SRCXX))
+    ifeq (,$(filter cpp,$(FEATURES_USED)))
+      $(error Found C++ source, but feature "cpp" is not used. Add "FEATURES_REQUIRED += cpp")
</pre>
<p>How is this checked when using Kconfig?</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16483#discussion_r658606827">sys/Makefile.dep</a>:</p>
<pre style='color:#555'>> @@ -6,8 +6,7 @@ ifneq (,$(filter arduino,$(USEMODULE)))
   FEATURES_REQUIRED += cpp
   FEATURES_REQUIRED += periph_gpio
   FEATURES_REQUIRED += periph_uart
-  SKETCH_MODULE ?= arduino_sketches
-  USEMODULE += $(SKETCH_MODULE)
+  USEMODULE += arduino_sketches
</pre>
<p>It seems like this does more than 'fix kconfig of arduino', probably worth its own commit at least.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16483#discussion_r658607282">boards/common/nucleo/Kconfig</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,17 @@
+# Copyright (c) 2021 HAW Hamburg
+#
+# This file is subject to the terms and conditions of the GNU Lesser
+# General Public License v2.1. See the file LICENSE in the top level
+# directory for more details.
+#
+
+if TEST_KCONFIG
+
+config MODULE_BOARDS_COMMON_NUCLEO
+    bool
+    default y
+    select MODULE_SAUL_GPIO if MODULE_SAUL_DEFAULT
</pre>
<p>should <code>HAS_PERIPH_GPIO</code> be checked here?</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16483#discussion_r658608200">cpu/stm32/periph/Kconfig</a>:</p>
<pre style='color:#555'>> +    help
+        stm32 can bus peripheral.
</pre>
<p>No sure about the help string, how is this resolved against the other definition?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/16483#pullrequestreview-692608353">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYAXK4CMECAIVXPQ2L3TURAM5ANCNFSM45E6TFYA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYB25TWJOTTBWYRIIRLTURAM5A5CNFSM45E6TFYKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFFEF2YI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/16483#pullrequestreview-692608353",
"url": "https://github.com/RIOT-OS/RIOT/pull/16483#pullrequestreview-692608353",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>