<p></p>
<p><b>@benpicco</b> commented on this pull request.</p>

<p>looks good, just some style nits</p><hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16533#discussion_r663503162">drivers/netdev_ieee802154_submac/netdev_ieee802154_submac.c</a>:</p>
<pre style='color:#555'>> @@ -291,8 +291,28 @@ static int _init(netdev_t *netdev)
         (netdev_ieee802154_submac_t *)netdev;
     ieee802154_submac_t *submac = &netdev_submac->submac;
     netdev_ieee802154_t *netdev_ieee802154 = (netdev_ieee802154_t *)netdev;
-    ieee802154_submac_init(submac, (network_uint16_t*) netdev_ieee802154->short_addr, (eui64_t*) netdev_ieee802154->long_addr);
+    netdev_ieee802154_setup(netdev_ieee802154);
+
+    int res = ieee802154_submac_init(submac, (network_uint16_t*) netdev_ieee802154->short_addr, (eui64_t*) netdev_ieee802154->long_addr);
</pre>

⬇️ Suggested change
<pre style="color: #555">-    int res = ieee802154_submac_init(submac, (network_uint16_t*) netdev_ieee802154->short_addr, (eui64_t*) netdev_ieee802154->long_addr);
+    int res = ieee802154_submac_init(submac,
+                                     (network_uint16_t*) netdev_ieee802154->short_addr,
+                                     (eui64_t*) netdev_ieee802154->long_addr);
</pre>


<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16533#discussion_r663503720">sys/net/link_layer/ieee802154/submac.c</a>:</p>
<pre style='color:#555'>>  
     ieee802154_radio_config_phy(dev, &conf);
     assert(ieee802154_radio_set_cca_threshold(dev,
                                               CONFIG_IEEE802154_CCA_THRESH_DEFAULT) >= 0);
 
-    ieee802154_radio_request_set_trx_state(dev, IEEE802154_TRX_STATE_RX_ON);
+    _req_set_trx_state_wait_busy(dev, IEEE802154_TRX_STATE_RX_ON);
+    while(ieee802154_radio_confirm_set_trx_state(dev) == -EAGAIN) {};
</pre>

⬇️ Suggested change
<pre style="color: #555">-    while(ieee802154_radio_confirm_set_trx_state(dev) == -EAGAIN) {};
+    while (ieee802154_radio_confirm_set_trx_state(dev) == -EAGAIN) {};
</pre>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/16533#pullrequestreview-698674286">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYH5KSNKI6SQ476XEOTTWBOIDANCNFSM46HQTYPQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYEIXVRSMRTEPB3ALULTWBOIDA5CNFSM46HQTYP2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFGSOY3Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/16533#pullrequestreview-698674286",
"url": "https://github.com/RIOT-OS/RIOT/pull/16533#pullrequestreview-698674286",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>