<p></p>
<p><b>@leandrolanzieri</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/15671#discussion_r664329229">pkg/mbedtls/Kconfig</a>:</p>
<pre style='color:#555'>> +
+menuconfig KCONFIG_USEMODULE_MBEDTLS
+    bool "Configure mbed TLS"
+    help
+        Configure mbed TLS using Kconfig.
+
+if KCONFIG_USEMODULE_MBEDTLS
+
+config MBEDTLS_SELF_TEST
+    bool "Enable the checkup functions (*_self_test)"
+    default y
+
+config MBEDTLS_ENTROPY_C
+    bool "Enable the platform-specific entropy code."
+    default y
+    depends on MBEDTLS_SHA256_C || MBEDTLS_SHA512_C
</pre>
<p>Where is <code>MBEDTLS_SHA512_C</code> being defined?</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/15671#discussion_r664330411">pkg/mbedtls/contrib/entropy/Kconfig</a>:</p>
<pre style='color:#555'>> +    help
+        Configure mbed TLS mbedtls entropy using Kconfig.
+
+if KCONFIG_USEMODULE_MBEDTLS_ENTROPY
+
+config MBEDTLS_ENTROPY_HARDWARE_ALT
+    bool "Let mbed TLS use your own implementation of a hardware entropy collector"
+    default y
+    help
+        Your function must be called
+        mbedtls_hardware_poll(), have the same prototype
+        as declared in entropy_poll.h, and accept NULL as
+        first argument.
+
+config MBEDTLS_NO_PLATFORM_ENTROPY
+    bool "Enable this macro to disable the built-in platform entropy functions"
</pre>

⬇️ Suggested change
<pre style="color: #555">-    bool "Enable this macro to disable the built-in platform entropy functions"
+    bool "Disable the built-in platform entropy functions"
</pre>


<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/15671#discussion_r664333112">pkg/mbedtls/include/riot_config.h</a>:</p>
<pre style='color:#555'>> +#if IS_ACTIVE(CONFIG_MBEDTLS_SHA256_ALT)
 #define MBEDTLS_SHA256_ALT 1
+#endif
</pre>
<p>I think this may cause confusion. If the exposed configuration parameters to the user are the <code>CONFIG_</code> ones, then that's what should be documented in Doxygen. So in this case the user should find <code>CONFIG_MBEDTLS_SHA256_ALT</code> instead of <code>MBEDTLS_SHA256_ALT</code>.</p>
<p>Additionally, as all the configurations seem to default to <code>1</code>, we may need to guard them around a check for <code>CONFIG_KCONFIG_USEMODULE_MBEDTLS</code>, because <code>false</code> in Kconfig translates to a not defined macro.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/15671#pullrequestreview-699654136">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYD7XJXG2UX67D4LU3LTWK4B3ANCNFSM4VABCUGA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYEJIONWGCWTGYAA3MLTWK4B3A5CNFSM4VABCUGKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFGZ576A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/15671#pullrequestreview-699654136",
"url": "https://github.com/RIOT-OS/RIOT/pull/15671#pullrequestreview-699654136",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>