<p></p>
<p><b>@akshaim</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16599#discussion_r666015660">drivers/sx126x/sx126x_netdev.c</a>:</p>
<pre style='color:#555'>> @@ -288,8 +288,9 @@ static int _set_state(sx126x_t *dev, netopt_state_t state)
     case NETOPT_STATE_RX:
         DEBUG("[sx126x] netdev: set NETOPT_STATE_RX state\n");
         sx126x_cfg_rx_boosted(dev, true);
-        if (dev->rx_timeout != 0) {
-            sx126x_set_rx(dev, dev->rx_timeout);
+        const int _timeout = (sx126x_symbol_to_msec(dev, dev->rx_timeout));
</pre>
<p>Just to be safe, compile optimisation and adding some clarity. The variable should only be set via <code>sx126x_symbol_to_msec</code> , wrong values will break the stack.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/16599#discussion_r666015660">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYDNYQGO56UYGENZEKLTWVT3NANCNFSM47S2ZZUA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYHC2MKVXD6OJOSESX3TWVT3NA5CNFSM47S2ZZUKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFHKQPVY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/16599#discussion_r666015660",
"url": "https://github.com/RIOT-OS/RIOT/pull/16599#discussion_r666015660",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>