<p></p>
<p><b>@Ollrogge</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16489#discussion_r666130085">sys/fido2/ctap/ctap_crypto.c</a>:</p>
<pre style='color:#555'>> +    }
+
+    memmove(r_raw, sig, sizeof(r_raw));
+    memmove(s_raw, sig + sizeof(r_raw), sizeof(s_raw));
+
+    ret = sig_to_der_format(r_raw, s_raw, sig, sig_size);
+
+    if (ret != CTAP2_OK) {
+        return ret;
+    }
+
+    return CTAP2_OK;
+}
+
+/* Encode signature in ASN.1 DER format */
+static int sig_to_der_format(uint8_t *r, uint8_t *s, uint8_t *sig,
</pre>
<p>I didn't know about the ASN.1 package. I change the implementation to use this PKG.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/16489#discussion_r666130085">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYDQ7NK7CGGZUD6RTVLTWWIANANCNFSM45IUCTGA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYHWJED5V5A4YYNZCHLTWWIANA5CNFSM45IUCTGKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFHLVKAQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/16489#discussion_r666130085",
"url": "https://github.com/RIOT-OS/RIOT/pull/16489#discussion_r666130085",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>