<p></p>
<p><b>@akshaim</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/15995#discussion_r668069569">sys/net/gnrc/link_layer/lorawan/gnrc_lorawan_mcps.c</a>:</p>
<pre style='color:#555'>> @@ -251,6 +258,15 @@ size_t gnrc_lorawan_build_uplink(gnrc_lorawan_t *mac, iolist_t *payload,
     lw_hdr->addr = mac->dev_addr;
     lw_hdr->fctrl = 0;
 
+    lorawan_hdr_set_adr(lw_hdr,mac->mlme.adr);
+
+    /* Set `ADRACKReq` bit and ADR_ACK_CNT */
+    if (mac->mlme.adr) {
+        lorawan_hdr_set_adr_ack_req(lw_hdr,
</pre>
<p>Okay, makes sense to move the condition one line up.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/15995#discussion_r668069569">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYDEWW4HUC4OO7BHEBDTXMICXANCNFSM4XQ67POQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYGWH5DRYXHKO5B2NRLTXMICXA5CNFSM4XQ67PO2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFH5MCXA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/15995#discussion_r668069569",
"url": "https://github.com/RIOT-OS/RIOT/pull/15995#discussion_r668069569",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>