<p></p>
<p><b>@jia200x</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/15995#discussion_r671373683">sys/net/gnrc/link_layer/lorawan/gnrc_lorawan.c</a>:</p>
<pre style='color:#555'>> @@ -107,6 +108,7 @@ void gnrc_lorawan_reset(gnrc_lorawan_t *mac)
 
     dev->driver->set(dev, NETOPT_RX_TIMEOUT, &rx_timeout, sizeof(rx_timeout));
 
+    mac->last_dr = CONFIG_LORAMAC_DEFAULT_DR;
</pre>
<p>ADR doesn't need a default value to start with. Even more, why would a function that sets the <code>rx2_dr</code> would change the last DR at all? this makes no sense to me...</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/15995#discussion_r671373683">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYFAG2JL3GMY6U5GV63TYBLGLANCNFSM4XQ67POQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYHDAC25DIWQIRQAUNTTYBLGLA5CNFSM4XQ67PO2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFI52GMQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/15995#discussion_r671373683",
"url": "https://github.com/RIOT-OS/RIOT/pull/15995#discussion_r671373683",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>