<p></p>
<p><b>@jia200x</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/15995#discussion_r671297387">sys/net/gnrc/link_layer/lorawan/gnrc_lorawan_mlme.c</a>:</p>
<pre style='color:#555'>> +           p[last_adr_pos + 1] >> 4, p[last_adr_pos + 1] & 0x0f);
+    DEBUG("gnrc_lorawan_mlme: LinkADRReq ChMask : %u\n", (p[last_adr_pos + 3] << 8 ) \
+                                                          | p[last_adr_pos + 2]);
+    DEBUG("gnrc_lorawan_mlme: LinkADRReq Redundancy : %u\n", p[last_adr_pos + 4]);
+
+    DEBUG("gnrc_lorawan_mlme: Lastdr : %u\n",mac->last_dr); // to be removed
+    DEBUG("gnrc_lorawan_mlme: Channel Mask : %u\n",mac->channel_mask); // to be removed
+
+    mac->mlme.adr_req_recv = true;
+    return index;
+}
+
+int _fopts_mlme_link_adr_ans(lorawan_buffer_t *buf)
+{
+    if (buf) {
+        assert(buf->index + GNRC_LORAWAN_CID_SIZE <= buf->size);
</pre>

⬇️ Suggested change
<pre style="color: #555">-        assert(buf->index + GNRC_LORAWAN_CID_SIZE <= buf->size);
+        assert(buf->index + GNRC_LORAWAN_CID_LINK_ADR_ANS <= buf->size);
</pre>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/15995#pullrequestreview-708449196">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYGHJB2IV5YKCSSICPDTYA6QXANCNFSM4XQ67POQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYAUNJLJT2QO23B5TJDTYA6QXA5CNFSM4XQ67PO2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFI5BHLA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/15995#pullrequestreview-708449196",
"url": "https://github.com/RIOT-OS/RIOT/pull/15995#pullrequestreview-708449196",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>