<p></p>
<p><b>@fjmolinas</b> commented on this pull request.</p>

<p>Looks good, some minor comments..</p><hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16654#discussion_r672044791">tests/unittests/tests-gnrc_lorawan/tests-gnrc_lorawan.c</a>:</p>
<pre style='color:#555'>> +static uint8_t nwkskey[] = {0x44, 0x02, 0x42, 0x41, 0xed, 0x4c, 0xe9, 0xa6, 0x8c, 0x6a, 0x8b, 0xc0, 0x55, 0x23, 0x3f, 0xd3};
+static uint8_t lorawan_packet_no_mic[] = {0x40, 0xF1, 0x7D, 0xBE, 0x49, 0x00, 0x02, 0x00, 0x01, 0x95, 0x43, 0x78, 0x76};
+static uint8_t lorawan_packet_wrong[] = {0x40, 0xF1, 0x7D, 0x00, 0x49, 0x00, 0x02, 0xAA, 0x01, 0x95, 0x43, 0x78, 0x76};
+static uint8_t mic[] = {0x2B, 0x11, 0xFF, 0x0D};
+static le_uint32_t dev_addr ={
+   .u8 =  {0xF1, 0x7D, 0xBE, 0x49}
+};
</pre>
<p>Seems this file could be uncrustified</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/16654#pullrequestreview-709222681">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYAWBYFRMW4DPX6P7ATTYPGXJANCNFSM5AP4UG3Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYBL2N454OBRJIVTUEDTYPGXJA5CNFSM5AP4UG32YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFJC6CGI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/16654#pullrequestreview-709222681",
"url": "https://github.com/RIOT-OS/RIOT/pull/16654#pullrequestreview-709222681",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>