<p></p>
<p><b>@benpicco</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16634#discussion_r673355419">tests/netutils/mock_dns.c</a>:</p>
<pre style='color:#555'>> + * @{
+ *
+ * @file
+ * @brief       Mock implementation of sock_dns
+ *
+ * @author      Benjamin Valentin <benjamin.valentin@ml-pa.com>
+ */
+#include <string.h>
+
+#include "net/af.h"
+#include "net/ipv6/addr.h"
+#include "net/sock/dns.h"
+
+int sock_dns_query(const char *domain_name, void *addr_out, int family)
+{
+    const ipv6_addr_t a = { {
</pre>
<p><code>const</code> should always go to .text / ROM, not on the stack.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/16634#discussion_r673355419">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYDIKZ5YAYSZZ26NIT3TYWZS5ANCNFSM5AEHUGEQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYDDFKAZBA3MQ7MLPK3TYWZS5A5CNFSM5AEHUGE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFJPZZBA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/16634#discussion_r673355419",
"url": "https://github.com/RIOT-OS/RIOT/pull/16634#discussion_r673355419",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>