<p></p>
<p><b>@akshaim</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/15995#discussion_r673266209">sys/net/gnrc/link_layer/lorawan/gnrc_lorawan_mlme.c</a>:</p>
<pre style='color:#555'>> +        channel_mask = 0;
+        for (unsigned i = 0; i < GNRC_LORAWAN_MAX_CHANNELS; i++) {
+            if (mac->channel[i]) {
+                channel_mask |= 1;
+            }
+            channel_mask = channel_mask << 1;
+        }
+        int res = gnrc_lorawan_phy_set_channel_mask(mac, channel_mask);
+        (void) res;
+        assert(res >= 0);
+        status |= 0x1;
+    }
+    else if (chmask_ctrl == 0) {
+        /* Try to apply channel mask */
+        if (gnrc_lorawan_phy_set_channel_mask(mac, channel_mask) >= 0) {
+            status |= 0x1;
</pre>
<p>One is enabling all channels irrespective of the <code>ChMask</code> value in  <code>LinkADRReq</code>, other is setting the same based on <code>ChMask</code> in  <code>LinkADRReq</code>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/15995#discussion_r673266209">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYFR7RR24SPKNMLPXI3TYWN5RANCNFSM4XQ67POQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYAEDUOEDZ7ICIHHCITTYWN5RA5CNFSM4XQ67PO2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFJOY2DA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/15995#discussion_r673266209",
"url": "https://github.com/RIOT-OS/RIOT/pull/15995#discussion_r673266209",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>