<p></p>
<p><b>@miri64</b> approved this pull request.</p>

<p>Final nits. Please squash immediately.</p><hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16634#discussion_r673345064">tests/netutils/main.c</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,158 @@
+/*
+ * Copyright (C) Copyright (C) 2021 ML!PA Consulting GmbH
+ *
+ * This file is subject to the terms and conditions of the GNU Lesser
+ * General Public License v2.1. See the file LICENSE in the top level
+ * directory for more details.
+ */
+
+/**
+ * @{
+ *
+ * @file
+ *
+ * @author      Benjamin Valentin <benjamin.valentin@ml-pa.com>
+* @author      Martine Lenders <mlenders@inf.fu-berlin.de>
</pre>
<p>I think I can be removed from that. Nothing in this file is particularly me. ;-).</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16634#discussion_r673346122">tests/netutils/mock_dns.c</a>:</p>
<pre style='color:#555'>> + * @{
+ *
+ * @file
+ * @brief       Mock implementation of sock_dns
+ *
+ * @author      Benjamin Valentin <benjamin.valentin@ml-pa.com>
+ */
+#include <string.h>
+
+#include "net/af.h"
+#include "net/ipv6/addr.h"
+#include "net/sock/dns.h"
+
+int sock_dns_query(const char *domain_name, void *addr_out, int family)
+{
+    const ipv6_addr_t a = { {
</pre>

⬇️ Suggested change
<pre style="color: #555">-    const ipv6_addr_t a = { {
+    static const ipv6_addr_t a = { {
</pre>

<p>might lead to a better stack usage, but I guess this is just premature optimization.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/16634#pullrequestreview-710897542">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYBYIA2MBBYNSTHUXYLTYWYIVANCNFSM5AEHUGEQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYF4M6XTKGJISQGGESTTYWYIVA5CNFSM5AEHUGE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFJPW7BQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/16634#pullrequestreview-710897542",
"url": "https://github.com/RIOT-OS/RIOT/pull/16634#pullrequestreview-710897542",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>