<p></p>
<p><b>@kfessel</b> commented on this pull request.</p>

<p>some time unit typos</p><hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16668#discussion_r673919600">sys/net/application_layer/dhcpv6/client.c</a>:</p>
<pre style='color:#555'>> @@ -208,7 +206,20 @@ static inline bool _is_tid(dhcpv6_msg_t *msg)
 
 static inline uint32_t _now_cs(void)
 {
+#if IS_USED(MODULE_ZTIMER)
+    return (uint32_t)(ztimer_now(ZTIMER_MSEC) / US_PER_CS);
</pre>
<p>reads like this should use <code>MS_PER_CS</code></p>

⬇️ Suggested change
<pre style="color: #555">-    return (uint32_t)(ztimer_now(ZTIMER_MSEC) / US_PER_CS);
+    return (uint32_t)(ztimer_now(ZTIMER_MSEC) / MS_PER_CS);
</pre>


<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16668#discussion_r673921119">sys/net/application_layer/dhcpv6/client.c</a>:</p>
<pre style='color:#555'>>      return (uint32_t)(xtimer_now_usec64() / US_PER_CS);
+#endif
+}
+
+static inline uint32_t _now_sec(void)
+{
+#if IS_USED(MODULE_ZTIMER)
+    return (uint32_t)ztimer_now(ZTIMER_MSEC);
</pre>
<p>needs a factor of 1/1000?</p>

⬇️ Suggested change
<pre style="color: #555">-    return (uint32_t)ztimer_now(ZTIMER_MSEC);
+    return (uint32_t)(ztimer_now(ZTIMER_MSEC) / MS_PER_SEC));
</pre>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/16668#pullrequestreview-711584712">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYG2A27UAEH2A5DBMUTTY24CXANCNFSM5AXY7UPA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYFAIKY2DPGU7YZNNWTTY24CXA5CNFSM5AXY7UPKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFJU6XSA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/16668#pullrequestreview-711584712",
"url": "https://github.com/RIOT-OS/RIOT/pull/16668#pullrequestreview-711584712",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>