<p></p>
<p><b>@miri64</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16669#discussion_r673956387">sys/net/application_layer/dns/msg.c</a>:</p>
<pre style='color:#555'>> @@ -7,31 +7,24 @@
  */
</pre>
<p>Just to avoid confusion in the review: I did not rename the file and then moved the <code>sock_dns</code> parts to <code>sys/net/application_layer/dns/dns.c</code>, rather I renamed <code>sys/net/application_layer/dns/dns.c</code> to <code>sys/net/application_layer/sock_dns/dns.c</code> and then moved the message composition and parsing parts from <code>sys/net/application_layer/sock_dns/dns.c</code> to this <code>sys/net/application_layer/dns/msg.c</code>. However, since that was the majority of <code>sys/net/application_layer/sock_dns/dns.c</code>'s content, Git interpreted it as a rename.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/16669#pullrequestreview-711633496">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYCYK6I7BXFW2LEZGE3TY3BKHANCNFSM5AX5H6IA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYFYT2DLFZ4UVG4ACA3TY3BKHA5CNFSM5AX5H6IKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFJVKUWA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/16669#pullrequestreview-711633496",
"url": "https://github.com/RIOT-OS/RIOT/pull/16669#pullrequestreview-711633496",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>