<p></p>
<p><b>@Ollrogge</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16489#discussion_r674121805">sys/include/fido2/ctap/transport/hid/ctap_transport_hid.h</a>:</p>
<pre style='color:#555'>> + */
+
+/**
+ * @defgroup    fido2_ctap_transport_hid CTAP USB_HID transport binding - CTAPHID
+ * @ingroup     fido2_ctap_transport
+ * @brief       CTAP_HID defines and functions
+ *
+ * @{
+ *
+ * @file
+ * @brief       Definition for CTAPHID helper functions
+ *
+ * @author      Nils Ollrogge <nils-ollrogge@outlook.de>
+ */
+
+#ifndef FIDO2_CTAP_TRANSPORT_HID_CTAP_TRANSPORT_HID_H
</pre>
<p>It looks bad but based on the coding conventions all header guards should look like <code>PATH_TO_FILE_FILENAME_H</code>.<br>
Path is fido2/ctap/transport/hid filename is ctap_transport_hid.h</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/16489#discussion_r674121805">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYDC7F5ZN66ORQ3O6QDTY3VOZANCNFSM45IUCTGA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYDN5J43LQXLCGSVJ4TTY3VOZA5CNFSM45IUCTGKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFJXHTHY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/16489#discussion_r674121805",
"url": "https://github.com/RIOT-OS/RIOT/pull/16489#discussion_r674121805",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>