<p></p>
<p><b>@jue89</b> requested changes on this pull request.</p>

<p>I think this will improve intelligibility for first-time readers stumbling over the this UART feature.</p><hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16506#discussion_r676490079">cpu/sam0_common/Kconfig</a>:</p>
<pre style='color:#555'>> @@ -21,6 +21,7 @@ config CPU_COMMON_SAM0
     select HAS_PERIPH_UART_MODECFG
     select HAS_PERIPH_UART_NONBLOCKING
     select HAS_PERIPH_UART_RECONFIGURE
+    select HAS_PERIPH_UART_RX_START
</pre>
<p>I think this is more descriptive:</p>

⬇️ Suggested change
<pre style="color: #555">-    select HAS_PERIPH_UART_RX_START
+    select HAS_PERIPH_UART_RXSTART_IRQ
</pre>


<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16506#discussion_r676490107">cpu/sam0_common/Makefile.features</a>:</p>
<pre style='color:#555'>> @@ -19,6 +19,7 @@ FEATURES_PROVIDED += periph_timer_periodic # implements timer_set_periodic()
 FEATURES_PROVIDED += periph_uart_modecfg
 FEATURES_PROVIDED += periph_uart_nonblocking
 FEATURES_PROVIDED += periph_uart_reconfigure
+FEATURES_PROVIDED += periph_uart_rx_start
</pre>
<p>I think this is more descriptive.</p>

⬇️ Suggested change
<pre style="color: #555">-FEATURES_PROVIDED += periph_uart_rx_start
+FEATURES_PROVIDED += periph_uart_rxstart_irq
</pre>


<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16506#discussion_r676495877">drivers/include/periph/uart.h</a>:</p>
<pre style='color:#555'>> @@ -243,6 +254,36 @@ gpio_t uart_pin_tx(uart_t uart);
 #endif /* DOXYGEN */
 #endif /* MODULE_PERIPH_UART_RECONFIGURE */
 
+#if defined(MODULE_PERIPH_UART_RX_START) || DOXYGEN
+
+/**
+ * @brief   Configure the function that will be called when a start condition
+ *          is detected.
+ *
+ *          This will not enable / disable the generation of the RX start
+ *          interrupt.
+ *
</pre>

⬇️ Suggested change
<pre style="color: #555">- *
+ *
+ * @note    You have to add the module `periph_uart_rxstart_irq` to your project
+ *          to enable this function
+ *
</pre>


<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16506#discussion_r676496334">drivers/include/periph/uart.h</a>:</p>
<pre style='color:#555'>> +/**
+ * @brief   Configure the function that will be called when a start condition
+ *          is detected.
+ *
+ *          This will not enable / disable the generation of the RX start
+ *          interrupt.
+ *
+ * @param[in] uart      The device to configure
+ * @param[in] cb        The function called when a start condition is detected
+ * @param[in] arg       Optional function argument
+ */
+void uart_rxstart_configure(uart_t uart, uart_rxstart_cb_t cb, void *arg);
+
+/**
+ * @brief   Enable the RX start interrupt.
+ *
</pre>

⬇️ Suggested change
<pre style="color: #555">- *
+ *
+ * @note    You have to add the module `periph_uart_rxstart_irq` to your project
+ *          to enable this function
+ *
</pre>


<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16506#discussion_r676496416">drivers/include/periph/uart.h</a>:</p>
<pre style='color:#555'>> + * @param[in] uart      The device to configure
+ * @param[in] cb        The function called when a start condition is detected
+ * @param[in] arg       Optional function argument
+ */
+void uart_rxstart_configure(uart_t uart, uart_rxstart_cb_t cb, void *arg);
+
+/**
+ * @brief   Enable the RX start interrupt.
+ *
+ * @param[in] uart      The device to configure
+ */
+void uart_rxstart_enable(uart_t uart);
+
+/**
+ * @brief   Disable the RX start interrupt.
+ *
</pre>

⬇️ Suggested change
<pre style="color: #555">- *
+ *
+ * @note    You have to add the module `periph_uart_rxstart_irq` to your project
+ *          to enable this function
+ *
</pre>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/16506#pullrequestreview-714696649">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYEX2LYJKH3FUHPMN6LTZU475ANCNFSM45VF75LA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYEMPLTFILJ7M5UB4LDTZU475A5CNFSM45VF75LKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFKMWPSI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/16506#pullrequestreview-714696649",
"url": "https://github.com/RIOT-OS/RIOT/pull/16506#pullrequestreview-714696649",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>