<p></p>
<p><b>@miri64</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16672#discussion_r678437662">sys/net/gnrc/routing/rpl/gnrc_rpl.c</a>:</p>
<pre style='color:#555'>> @@ -419,6 +419,18 @@ uint8_t gnrc_rpl_gen_instance_id(bool local)
     return instance_id;
 }
 
+void gnrc_rpl_configure_root(gnrc_netif_t *netif)
+{
+    gnrc_rpl_init(netif->pid);
+    gnrc_rpl_instance_t *inst = gnrc_rpl_instance_get(
+            CONFIG_GNRC_RPL_DEFAULT_INSTANCE
+        );
+    if (inst) {
+        gnrc_rpl_instance_remove(inst);
+    }
+    gnrc_rpl_root_init(CONFIG_GNRC_RPL_DEFAULT_INSTANCE, &addr, false, false);
</pre>
<p>Why not just provide it as a parameter? Guessing the address the DODAG should be opened on (is the one returned by <code>get_global()</code> really the one configured by the config protocol) seems like a bad idea. Not to mention that I do not see much use in such a guessing function in general.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/16672#discussion_r678437662">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYHX2CNIK6NPHWJRDKDT2ARXZANCNFSM5A2EDGWQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYCH2WJBFS4TWPI3CVDT2ARXZA5CNFSM5A2EDGW2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFK7WC4A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/16672#discussion_r678437662",
"url": "https://github.com/RIOT-OS/RIOT/pull/16672#discussion_r678437662",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>