<p></p>
<p><b>@dylad</b> requested changes on this pull request.</p>

<p>One small change, otherwise looks good.</p><hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16694#discussion_r679822138">boards/saml21-xpro/include/periph_conf.h</a>:</p>
<pre style='color:#555'>> +        .tx_trigger = SERCOM0_DMAC_ID_TX,
+        .rx_trigger = SERCOM0_DMAC_ID_RX,
</pre>
<p>Nope.</p>

⬇️ Suggested change
<pre style="color: #555">-        .tx_trigger = SERCOM0_DMAC_ID_TX,
-        .rx_trigger = SERCOM0_DMAC_ID_RX,
+        .tx_trigger = SERCOM5_DMAC_ID_TX,
+        .rx_trigger = SERCOM5_DMAC_ID_RX,
</pre>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/16694#pullrequestreview-718941165">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYF3U3FX7MMRUWLYG5DT2J5NJANCNFSM5BIF5WAQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABE7WYGHRSMFRMQOTGTR6DLT2J5NJA5CNFSM5BIF5WA2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFLNCX3I.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/16694#pullrequestreview-718941165",
"url": "https://github.com/RIOT-OS/RIOT/pull/16694#pullrequestreview-718941165",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>