<p></p>
<p><b>@Ollrogge</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16689#discussion_r682483625">sys/include/usb/usbus/hid_io.h</a>:</p>
<pre style='color:#555'>> + */
+typedef struct {
+    usb_hid_io_cb_t cb;         /**< callback function to call */
+    void *arg;                  /**< argument to pass to callback function */
+} usb_hid_io_t;
+
+/**
+ * @brief Set USBUS HID IO RX callback
+ *
+ * @param[in]   usb_hid_io  usb_hid_io structure to use
+ */
+void usb_hid_io_set_rx_cb(usb_hid_io_t* usb_hid_io);
+
+/**
+ * @brief Write data to USB HID IN endpoint buffer
+ *
</pre>
<p>Just a general question: Why only check that buffer is null ? If I add this shouldn't I also add e.g. <code>assert(usbus)</code> in <code>usb_hid_io_init</code>? I gues any public function that gets passed a pointer should chechk that it is != NULL ?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/16689#discussion_r682483625">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYGJYSL4CV4CCFVPVDDT3EHU7ANCNFSM5BFBSL4Q">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email">Android</a>.<img src="https://github.com/notifications/beacon/ABE7WYHBEUZHL23WVYVLQ7LT3EHU7A5CNFSM5BFBSL42YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFMFIOYY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/16689#discussion_r682483625",
"url": "https://github.com/RIOT-OS/RIOT/pull/16689#discussion_r682483625",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>