<p></p>
<p><b>@benpicco</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16678#discussion_r691132633">drivers/lm75/lm75.c</a>:</p>
<pre style='color:#555'>> +#define LM75_SHUTDOWN_MODE      0x01
+#define LM75_OS_POLARITY        0x04
</pre>
<p>Those are both for the CONFIG register right?</p>

⬇️ Suggested change
<pre style="color: #555">-#define LM75_SHUTDOWN_MODE      0x01
-#define LM75_OS_POLARITY        0x04
+#define LM75_CONFIG_SHUTDOWN        0x01
+#define LM75_CONFIG_OS_POLARITY     0x04
</pre>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/16678#pullrequestreview-732725428">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYETE4JOMJ7SW55FSFLT5OHS3ANCNFSM5A4D3GTA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email">Android</a>.<img src="https://github.com/notifications/beacon/ABE7WYH4JHLDXN4SC3FEQJDT5OHS3A5CNFSM5A4D3GTKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFOWIBNA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/16678#pullrequestreview-732725428",
"url": "https://github.com/RIOT-OS/RIOT/pull/16678#pullrequestreview-732725428",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>