<p></p>
<p><b>@benpicco</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16757#discussion_r692001458">cpu/sam0_common/periph/rtc_rtt.c</a>:</p>
<pre style='color:#555'>> +    int i;
+    for (i = 0; i < RTC_GPR_NUM; i++) persist[i] = RTC->MODE0.GP[i].reg;
</pre>

⬇️ Suggested change
<pre style="color: #555">-    int i;
-    for (i = 0; i < RTC_GPR_NUM; i++) persist[i] = RTC->MODE0.GP[i].reg;
+    for (unsigned i = 0; i < RTC_GPR_NUM; i++) {
+        persist[i] = RTC->MODE0.GP[i].reg;
+    }
</pre>

<p>No need to squish that all on one line <g-emoji class="g-emoji" alias="wink" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f609.png">😉</g-emoji></p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16757#discussion_r692001868">cpu/sam0_common/periph/rtc_rtt.c</a>:</p>
<pre style='color:#555'>> +#if CONFIG_SAM0_PERIPH_RTT_RTC_PERSIST_GPR
+#ifdef RTC_GPR_NUM
</pre>

⬇️ Suggested change
<pre style="color: #555">-#if CONFIG_SAM0_PERIPH_RTT_RTC_PERSIST_GPR
-#ifdef RTC_GPR_NUM
+#if IS_ACTIVE(CONFIG_SAM0_PERIPH_RTT_RTC_PERSIST_GPR) && defined(RTC_GPR_NUM)
</pre>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/16757#pullrequestreview-733842334">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYABH4K4DFBXMSTOSO3T5TO6RANCNFSM5CN6LQEQ">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email">Android</a>.<img src="https://github.com/notifications/beacon/ABE7WYDZNPKK3M5SX2LTZS3T5TO6RA5CNFSM5CN6LQE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFO6YXHQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/16757#pullrequestreview-733842334",
"url": "https://github.com/RIOT-OS/RIOT/pull/16757#pullrequestreview-733842334",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>