<p></p>
<p><b>@Ollrogge</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16489#discussion_r693863378">sys/fido2/ctap/ctap.c</a>:</p>
<pre style='color:#555'>> + */
+typedef struct {
+    uint8_t options;                    /**< options */
+    uint8_t aaguid[CTAP_AAGUID_SIZE];   /**< AAGUID of device */
+} ctap_config_t;
+
+/**
+ * @brief CTAP state struct
+ *
+ * state of authenticator. Stored in flash memory
+ */
+typedef struct {
+    uint8_t initialized_marker;                 /**< CTAP initialized marker */
+    bool pin_is_set;                            /**< PIN is set or not */
+    int rem_pin_att;                            /**< remaining PIN tries */
+    uint8_t pin_hash[SHA256_DIGEST_LENGTH / 2]; /**< LEFT(SHA-256(pin), 16) */
</pre>
<p>Not for this size. Only for the HMAC-SHA256 ones. I think using <code>SHA256_DIGEST_LENGTH / 2</code> is better though ? Maybe I just remove the other defines.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/16489#discussion_r693863378">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYGHB564TQAZYUQWC6DT6IRKBANCNFSM45IUCTGA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email">Android</a>.<img src="https://github.com/notifications/beacon/ABE7WYEXDEMXTZHVKHZ3GZTT6IRKBA5CNFSM45IUCTGKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFPPCCBI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/16489#discussion_r693863378",
"url": "https://github.com/RIOT-OS/RIOT/pull/16489#discussion_r693863378",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>