<p></p>
<p><b>@miri64</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16729#discussion_r694882872">sys/net/gnrc/network_layer/ipv6/nib/_nib-internal.c</a>:</p>
<pre style='color:#555'>> +            if (ipv6_addr_match_prefix(&netif->ipv6.addrs[i],
+                                       &pfx->pfx) >= pfx->pfx_len) {
+                gnrc_netif_ipv6_addr_remove_internal(netif,
+                                                     &netif->ipv6.addrs[i]);
+            }
</pre>
<blockquote>
<p>This code was just moved from <code>_handle_rtr_sol()</code> to it's own function.</p>
</blockquote>
<p>And yepp, I believe that one is also wrong ;-). It does not even stop the loop, after the address was removed...</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/16729#discussion_r694882872">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYHT23QE3DFFKXFGDELT6ORFDANCNFSM5CD24BFQ">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email">Android</a>.<img src="https://github.com/notifications/beacon/ABE7WYAFIIU3WH44I4Z6673T6ORFDA5CNFSM5CD24BF2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFPY5UJY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/16729#discussion_r694882872",
"url": "https://github.com/RIOT-OS/RIOT/pull/16729#discussion_r694882872",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>