<p></p>
<p><b>@miri64</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16731#discussion_r700962715">sys/net/application_layer/dhcpv6/client.c</a>:</p>
<pre style='color:#555'>>  static uint32_t t2, rebind_time;
 static uint32_t transaction_start;
 static uint32_t transaction_id;
 static uint8_t duid_len = sizeof(dhcpv6_duid_l2_t);
+uint8_t configuration_mode = DHCPV6_CLIENT_CONF_MODE_INACTIVE;
</pre>

⬇️ Suggested change
<pre style="color: #555">-uint8_t configuration_mode = DHCPV6_CLIENT_CONF_MODE_INACTIVE;
+static uint8_t configuration_mode = DHCPV6_CLIENT_CONF_MODE_INACTIVE;
</pre>


<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16731#discussion_r700963708">tests/gnrc_dhcpv6_client_stateless/Makefile</a>:</p>
<pre style='color:#555'>> +CFLAGS += -DCONFIG_GNRC_IPV6_NIB_SLAAC=1
+CFLAGS += -DCONFIG_GNRC_IPV6_NIB_ARSM=1
</pre>
<p>Please use Kconfig to configure these by adding the appropriate <code>app.config</code> to the application's directory.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16731#discussion_r700964643">tests/gnrc_dhcpv6_client_stateless/tests-as-root/01-run.py</a>:</p>
<pre style='color:#555'>> +    return sniffer
+
+
+def wait_for_dhcpv6_pkt(iface, sniffer=None, timeout=5):
+    if sniffer is None:
+        sniffer = start_sniffer(iface, "udp and dst port 547", count=3000)
+    sniffer.join(timeout=timeout)
+    if sniffer.results is None:
+        raise TimeoutError("Sniffing for DHCPv6 traffic timed out")
+    return [p for p in sniffer.results
+            # filter out packets only belonging to stop_filter if it existed
+            if sniffer.kwargs.get("stop_filter") is None or
+            sniffer.kwargs["stop_filter"](p)][-1]
+
+
+def wait_for_icmpv6_pkt(iface, sniffer=None, timeout=15):
</pre>
<p>Did not look into the test code in detail, but might it make sense to use a <a href="https://scapy.readthedocs.io/en/latest/advanced_usage.html#first-example" rel="nofollow">Scapy Automaton</a> for this?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/16731#pullrequestreview-744897839">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYDYW5HP2WAPYBZPV3LT75IHJANCNFSM5CD4TMAA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/ABE7WYHPMEJBRY4NBWMMUKLT75IHJA5CNFSM5CD4TMAKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFRTD2LY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/16731#pullrequestreview-744897839",
"url": "https://github.com/RIOT-OS/RIOT/pull/16731#pullrequestreview-744897839",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>