<p></p>
<p><b>@maribu</b> commented on this pull request.</p>

<p>looks good to me, some comments inline</p><hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16813#discussion_r702930048">cpu/sam3/include/periph_cpu.h</a>:</p>
<pre style='color:#555'>> @@ -30,6 +30,7 @@ extern "C" {
 
 /**
  * @brief Overwrite the default gpio_t type definition
</pre>
<p>If I recall correctly, grouping only works with <code>@name</code> instead of <code>@brief</code></p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16813#discussion_r702930415">cpu/samd5x/include/periph_cpu.h</a>:</p>
<pre style='color:#555'>> + * @brief   ADC resolution values
+ * @{
</pre>

⬇️ Suggested change
<pre style="color: #555">- * @brief   ADC resolution values
- * @{
+ * @name   ADC resolution values
+ * @{
</pre>

<p>same</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16813#discussion_r702932279">cpu/saml1x/include/periph_cpu.h</a>:</p>
<pre style='color:#555'>> +/**
+ * @brief   ADC resolution values.
+ */
</pre>
<p>Note that this is hidden from Doxygen anyway. (IMO this is sensible to do for all <code>adc_rec_t</code> definitions except for the default in <code>drivers/include/periph/adc.h</code>.)</p>
<p>Maybe it makes more sense to just drop the doc for this type instead?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/16813#pullrequestreview-747259184">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYFNXZJXCCJ4MHT5XJDUATELFANCNFSM5DPCSO3Q">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/ABE7WYDR3NEBI7DAL4OT2YLUATELFA5CNFSM5DPCSO32YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFSFEKMA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/16813#pullrequestreview-747259184",
"url": "https://github.com/RIOT-OS/RIOT/pull/16813#pullrequestreview-747259184",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>