<p></p>
<p><b>@haukepetersen</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/16603#discussion_r705296518">pkg/nimble/netif/nimble_netif.c</a>:</p>
<pre style='color:#555'>>  {
-    assert(ad);
</pre>
<p>Because <code>nimble_netif_accept_direct()</code> does not use a payload, and thus this shard backend function does accept empty advertising data. But I should move this check up into <code>nimble_netif_accept()</code> -> will do</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/16603#discussion_r705296518">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYG5CFLM6HEGHIOBDYDUBCUKZANCNFSM47UDTZKA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/ABE7WYHPXAR4GOTU5WGTJ4LUBCUKZA5CNFSM47UDTZKKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFS4IOZI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/16603#discussion_r705296518",
"url": "https://github.com/RIOT-OS/RIOT/pull/16603#discussion_r705296518",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>