<p></p>
<p><b>@bergzand</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/RIOT-OS/RIOT/pull/14623#discussion_r705229925">sys/net/gnrc/routing/rpl/mrhof.c</a>:</p>
<pre style='color:#555'>> +        /* p1 is acceptable and p2 not */
+        return -1;
+    }
+
+    return 0;
+}
+
+static void reset(gnrc_rpl_dodag_t *dodag)
+{
+    /* Nothing to do in MRHOF */
+    (void) dodag;
+}
+
+/**
+ * Calculate rank additive based on the rank of the parent and the etx to the parent
+ * computed via MAX(pref_parent->rank, 1 + floor(MAX(parents->rank)/MinHopRankIncrease),
</pre>
<p>From the enumeration of section 3.3:</p>
<p>This is number 1.</p>
<p><a href="https://github.com/RIOT-OS/RIOT/blob/b695b6e4e5bf48f5edd4c1f718940dc3c2c86477/sys/net/gnrc/routing/rpl/mrhof.c#L175-L180">https://github.com/RIOT-OS/RIOT/blob/b695b6e4e5bf48f5edd4c1f718940dc3c2c86477/sys/net/gnrc/routing/rpl/mrhof.c#L175-L180</a></p>
<p>This is number 2.</p>
<p><a href="https://github.com/RIOT-OS/RIOT/blob/b695b6e4e5bf48f5edd4c1f718940dc3c2c86477/sys/net/gnrc/routing/rpl/mrhof.c#L182-L203">https://github.com/RIOT-OS/RIOT/blob/b695b6e4e5bf48f5edd4c1f718940dc3c2c86477/sys/net/gnrc/routing/rpl/mrhof.c#L182-L203</a></p>
<p>This iterates over the parents and take the advertised dag rank and increment it by MinHopRankIncrease</p>
<p>And number 3 is missing as far I know. Number 3 could probably merged into the for loop code of number 2 and take the max of the path through the parent (rank of one parent + etx to that parent).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/RIOT-OS/RIOT/pull/14623#discussion_r705229925">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABE7WYCGKS6DMTWTQNN3Z33UBCJMHANCNFSM4PJITZ5A">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/ABE7WYFCV4WRHBE5XUZHIK3UBCJMHA5CNFSM4PJITZ5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFS3SWRI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/RIOT-OS/RIOT/pull/14623#discussion_r705229925",
"url": "https://github.com/RIOT-OS/RIOT/pull/14623#discussion_r705229925",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>